Re: Namecoin Local PGP Keyserver Plugin
Posted: Sat Sep 16, 2017 5:32 am
Some preliminary review:
https://github.com/phelix/npkh/blob/8c8 ... er.py#L208
It's not immediately obvious to me what the purpose of idFprs is. Is this a cache of some kind? Maybe add some comments explaining this.
https://github.com/phelix/npkh/blob/8c8 ... er.py#L212
It's not immediately obvious what the threat model of proxy_to_standard_pks . It looks to me like this function assumes that the caller is responsible for verifying the authenticity of the data returned by the remote keyserver. Is that correct? Maybe add some comments about this.
https://github.com/phelix/npkh/blob/8c8 ... er.py#L231
It's not immediately obvious to me what searchFpr will contain. It looks like this might be a caching mechanism but I'm not certain. Adding some comments about this would be helpful.
https://github.com/phelix/npkh/blob/8c8 ... thproxy.py
It looks like you're distributing a copy of https://github.com/jgarzik/python-bitcoinrpc . Is that correct? I'd be more comfortable if there were instead a dependency on the original version, so that users don't have to audit whether your version is identical to Jeff Garzik's version.
I'll post some additional review later.
Cheers!
https://github.com/phelix/npkh/blob/8c8 ... er.py#L208
It's not immediately obvious to me what the purpose of idFprs is. Is this a cache of some kind? Maybe add some comments explaining this.
https://github.com/phelix/npkh/blob/8c8 ... er.py#L212
It's not immediately obvious what the threat model of proxy_to_standard_pks . It looks to me like this function assumes that the caller is responsible for verifying the authenticity of the data returned by the remote keyserver. Is that correct? Maybe add some comments about this.
https://github.com/phelix/npkh/blob/8c8 ... er.py#L231
It's not immediately obvious to me what searchFpr will contain. It looks like this might be a caching mechanism but I'm not certain. Adding some comments about this would be helpful.
https://github.com/phelix/npkh/blob/8c8 ... thproxy.py
It looks like you're distributing a copy of https://github.com/jgarzik/python-bitcoinrpc . Is that correct? I'd be more comfortable if there were instead a dependency on the original version, so that users don't have to audit whether your version is identical to Jeff Garzik's version.
I'll post some additional review later.
Cheers!