If there is a probability that this 2-3 lines will cause a hardfork (and there is by making spendable the genesis block coins) then we should ask Khal also.domob wrote:To summarise, my opinion is that we should add the transaction to the index in any case. Apart from that, I do not really care whether or not we include an additional check in CTransaction::ConnectInputs to reject spending of the genesis block coins. If it was only my choice, I would probably not include it. But if others prefer to keep them unspendable, I can add that, too. (It will only be 2-3 lines of code or so, not really a big problem.)
Can we agree on this? I'll provide a patch if yes.
However if you make it only more clearly coded(3 or 3+1 lines doesn't matter) but with no hardfork risk at all then I have no objection.
Anyway thanks that you observed this irregularity.