pull request submitted 21 days ago still not reviewed

Namecoin, NMControl
Post Reply
gpgcoin
Posts: 2
Joined: Sat Feb 15, 2014 4:21 am
os: linux

pull request submitted 21 days ago still not reviewed

Post by gpgcoin »

Hi!

FAQ of https://github.com/namecoin/namecoin has a typo:

Edit: Only branch namecoinq has the typo. Branch master is ok. What are the differences between those two branches? This FAQ exists only on github and the buggy one is the default one when one lands on github... any way of inverting this default?

namecoind first_update <name> <random> <value>
should be
namecoind name_firstupdate <name> <random> <value>

I posted an issue and a patch 21 days but nobody seems to care:
https://github.com/namecoin/namecoin/pull/42

It will take like 5 seconds of your time to commit.

Do you want help on this project? :-)

Thanks.

jérôme

phelix
Posts: 1634
Joined: Thu Aug 18, 2011 6:59 am

Re: pull request submitted 21 days ago still not reviewed

Post by phelix »

gpgcoin wrote:Hi!

FAQ of https://github.com/namecoin/namecoin has a typo:

Edit: Only branch namecoinq has the typo. Branch master is ok. What are the differences between those two branches? This FAQ exists only on github and the buggy one is the default one when one lands on github... any way of inverting this default?

namecoind first_update <name> <random> <value>
should be
namecoind name_firstupdate <name> <random> <value>

I posted an issue and a patch 21 days but nobody seems to care:
https://github.com/namecoin/namecoin/pull/42

It will take like 5 seconds of your time to commit.
done :mrgreen:
Do you want help on this project? :-)
Any help would certainly be appreciated.
nx.bit - some namecoin stats
nf.bit - shortcut to this forum

khal
Site Admin
Posts: 708
Joined: Mon May 09, 2011 5:09 pm
os: linux

Re: pull request submitted 21 days ago still not reviewed

Post by khal »

gpgcoin wrote: Edit: Only branch namecoinq has the typo. Branch master is ok. What are the differences between those two branches? This FAQ exists only on github and the buggy one is the default one when one lands on github... any way of inverting this default?
So, I did apply the merge only on one branch...
Thanks phelix & gpgcoin.
NamecoinID: id/khal
GPG : 9CC5B92E965D69A9
NMC: N1KHAL5C1CRzy58NdJwp1tbLze3XrkFxx9
BTC: 1KHAL8bUjnkMRMg9yd2dNrYnJgZGH8Nj6T

Register Namecoin domains with BTC
My bitcoin Identity - Send messages to bitcoin users
Charity Ad - Make a good deed without paying a cent

indolering
Posts: 801
Joined: Sun Aug 18, 2013 8:26 pm
os: mac

Re: pull request submitted 21 days ago still not reviewed

Post by indolering »

I've got a pull request that has been up there for a week. What's the best way to go about getting others to help out on pull requests and testing? Would giving more people pull/push privileges help?
DNS is much more than a key->value datastore.

indolering
Posts: 801
Joined: Sun Aug 18, 2013 8:26 pm
os: mac

Re: pull request submitted 21 days ago still not reviewed

Post by indolering »

gpgcoin wrote:Hi!

Do you want help on this project? :-)

Thanks.

jérôme
Oh, and YES PLEASE GOD. We are all stretched WAY to thin. What would you like to do?
DNS is much more than a key->value datastore.

Post Reply