Namecoin Forum

The following string needs to be updated:

"Your wallet automatically synchronizes with the Bitcoin network after a connection is established"

(That's part of the hover text over the exclamation mark that appears on the Overview screen during initial syncup.)

I don't see any other issues in testing the supplied Windows namecoin-qt binary, although I didn't put any coins into the wallet, so I wasn't able to check the GUI elements that require having coins. I haven't checked the source code, nor tried to build it from source, nor have I tried anything command-line-related other than the -testnet option (which works great).

biolizard89 wrote:The following string needs to be updated:

"Your wallet automatically synchronizes with the Bitcoin network after a connection is established"

(That's part of the hover text over the exclamation mark that appears on the Overview screen during initial syncup.)

done

domob wrote:The only thing I "insist" on is to remove the patch hunk that is only a change to a comment.

done

https://github.com/fsb4000/namecore/com ... f176e71b28

There are still a few strings containing "BTC" in ./src/*

cassini wrote:There are still a few strings containing "BTC" in ./src/*

Code: Select all

src/amount.cpp:30:   return strprintf("%d.%08d BTC/kB", nSatoshisPerK / COIN, nSatoshisPerK % COIN);
src/init.cpp:335:    strUsage += HelpMessageOpt("-mintxfee=<amt>", strprintf(_("Fees (in BTC/Kb) smaller than ...
src/init.cpp:337:    strUsage += HelpMessageOpt("-paytxfee=<amt>", strprintf(_("Fee (in BTC/kB) to add to ...
src/init.cpp:385:    strUsage += HelpMessageOpt("-minrelaytxfee=<amt>", strprintf(_("Fees (in BTC/Kb) smaller than ...
src/qt/bitcoinstrings.cpp:68:"Fees (in BTC/Kb) smaller than this are considered zero fee for relaying "
src/qt/bitcoinstrings.cpp:71:"Fees (in BTC/Kb) smaller than this are considered zero fee for transaction "
src/qt/bitcoinstrings.cpp:232:QT_TRANSLATE_NOOP(  ...  "Fee (in BTC/kB) to add to transactions you send (default: %s)")
src/qt/forms/coincontroldialog.ui:324:          <string notr="true">0.00 BTC</string>
src/rpcblockchain.cpp:405:     " \"value\" : x.xxx,  (numeric) The transaction value in btc\n"
src/rpcmisc.cpp:63:            " \"paytxfee\": x.xxxx,  (numeric) the transaction fee set in btc/kb\n"
src/rpcmisc.cpp:64:            " \"relayfee\": x.xxxx,  (numeric) minimum relay fee for non-free transactions in btc/kb\n"
src/rpcnet.cpp:404:            " \"relayfee\": x.xxxxxxxx,  (numeric) minimum relay fee for non-free transactions in btc/kb\n"
src/rpcrawtransaction.cpp:189: " \"value\" : x.xxx,   (numeric) The value in btc\n"
src/rpcrawtransaction.cpp:376: " \"address\":  ...  the value is the btc amount\n"
src/rpcrawtransaction.cpp:475: " \"value\" : x.xxx,   (numeric) The value in btc\n"

good job.
I added the changes to the previous commit
(git commit -a --amend)
https://github.com/fsb4000/namecore/com ... 5b087a296d
also I did rebase.
(git rebase namecoin/master)
will update .exe files soon
updated .exe files

biolizard89 wrote:The splash screen has poor contrast for the text that is overlaid on the Namecoin logo. This isn't a problem for Bitcoin-Qt, since the light shade of orange used by the Bitcoin logo contrasts well with the gray text, but the gray text is pretty similar in color to the shade of blue we use for the Namecoin logo. I'm not certain of the best way to fix this; any graphic designers want to comment here?

Not graphic designer but what if we will just change color from gray to black
Before:

After

just wondering, what's wrong?

my namecoin-qt.exe https://www.metascan-online.com/en/scan ... 878370b4aa
official bitcoin-qt.exe (0.10.2) https://www.metascan-online.com/en/scan ... e164e8cc0e

How I build:
1) Open MSYS and go to folder with namecoin
2) ./autogen.sh
3) 4) make
5) strip src/qt/namecoin-qt.exe
(also strip other binary files)

fsb4000 wrote:just wondering, what's wrong?

Everything is fine, you did a great job. Thank you very much.

I am fine with black text on the splash screen but would not mind grey either if it less of a hassle for Domob. We will decide on this later.

Please send me a Bitcoin address on this forum by PM or on bitcointalk by PM.

phelix wrote:

fsb4000 wrote:just wondering, what's wrong?

Everything is fine, you did a great job. Thank you very much.

I am fine with black text on the splash screen but would not mind grey either if it less of a hassle for Domob. We will decide on this later.

Please send me a Bitcoin address on this forum by PM or on bitcointalk by PM.

I don't think that black text would be hassle.
I created tree https://github.com/fsb4000/namecore/tree/black_text
It is just 1 line change: https://github.com/fsb4000/namecore/com ... 6bc4ac0b06

namecoin-qt(black).exe : https://yadi.sk/d/BP5sKFjYgz6JV

Yes, I know what I didn't add anything virus but I'm just curious if someone builds their own .exe for windows, will this site show the virus warning or not? If not then how do you build?

Thank you, I will send Bitcoin address now.

Created pull request(don't include black text): https://github.com/namecoin/namecore/pull/8

fsb4000 wrote:

phelix wrote:

fsb4000 wrote:just wondering, what's wrong?

Everything is fine, you did a great job. Thank you very much.

I am fine with black text on the splash screen but would not mind grey either if it less of a hassle for Domob. We will decide on this later.

Please send me a Bitcoin address on this forum by PM or on bitcointalk by PM.

I don't think that black text would be hassle.
I created tree https://github.com/fsb4000/namecore/tree/black_text
It is just 1 line change: https://github.com/fsb4000/namecore/com ... 6bc4ac0b06

namecoin-qt(black).exe : https://yadi.sk/d/BP5sKFjYgz6JV

Yes, I know what I didn't add anything virus but I'm just curious if someone builds their own .exe for windows, will this site show the virus warning or not? If not then how do you build?

Thank you, I will send Bitcoin address now.

Created pull request(don't include black text): https://github.com/namecoin/namecore/pull/8

Thanks for your excellent work on this. Black text seems to be a reasonable solution to me, and if it's 1 line then I don't see any reason not to merge it. I don't know what's causing the specific malware warning you noticed, but when I built an old version of namecoind (about 1.5 years ago) from source, several Windows antivirus programs claimed it was malware. I suspect they're using a whitelist, which of course will flag anything built from source non-reproducibly as malware. When I tested your .exe, I did so in a fresh VM to be safe, and I assume the other devs here did the same. (Trust but verify.)

Cheers!

Coins on the way. We increased the bounty a little for the good work (e.g. builds were not specifically asked).