Namecoin Core Qt Rebrand

biolizard89
Posts: 1982
Joined: Tue Jun 05, 2012 6:25 am
os: linux

Re: Namecoin Core Qt Rebrand

Post by biolizard89 » Fri May 29, 2015 8:13 am

The following string needs to be updated:

"Your wallet automatically synchronizes with the Bitcoin network after a connection is established"

(That's part of the hover text over the exclamation mark that appears on the Overview screen during initial syncup.)

I don't see any other issues in testing the supplied Windows namecoin-qt binary, although I didn't put any coins into the wallet, so I wasn't able to check the GUI elements that require having coins. I haven't checked the source code, nor tried to build it from source, nor have I tried anything command-line-related other than the -testnet option (which works great).
Jeremy Rand, Lead Namecoin Application Engineer
NameID: id/jeremy
DyName: Dynamic DNS update client for .bit domains.

Donations: BTC 1EcUWRa9H6ZuWPkF3BDj6k4k1vCgv41ab8 ; NMC NFqbaS7ReiQ9MBmsowwcDSmp4iDznjmEh5

fsb4000
Posts: 13
Joined: Thu Oct 09, 2014 4:27 pm
os: windows

Re: Namecoin Core Qt Rebrand

Post by fsb4000 » Fri May 29, 2015 10:08 am

biolizard89 wrote:The following string needs to be updated:

"Your wallet automatically synchronizes with the Bitcoin network after a connection is established"

(That's part of the hover text over the exclamation mark that appears on the Overview screen during initial syncup.)
done
domob wrote:The only thing I "insist" on is to remove the patch hunk that is only a change to a comment.
done

https://github.com/fsb4000/namecore/com ... f176e71b28

cassini
Posts: 336
Joined: Sun May 26, 2013 6:36 pm

Re: Namecoin Core Qt Rebrand

Post by cassini » Sat May 30, 2015 10:53 pm

There are still a few strings containing "BTC" in ./src/*

Code: Select all

src/amount.cpp:30:   return strprintf("%d.%08d BTC/kB", nSatoshisPerK / COIN, nSatoshisPerK % COIN);
src/init.cpp:335:    strUsage += HelpMessageOpt("-mintxfee=<amt>", strprintf(_("Fees (in BTC/Kb) smaller than ...
src/init.cpp:337:    strUsage += HelpMessageOpt("-paytxfee=<amt>", strprintf(_("Fee (in BTC/kB) to add to ...
src/init.cpp:385:    strUsage += HelpMessageOpt("-minrelaytxfee=<amt>", strprintf(_("Fees (in BTC/Kb) smaller than ...
src/qt/bitcoinstrings.cpp:68:"Fees (in BTC/Kb) smaller than this are considered zero fee for relaying "
src/qt/bitcoinstrings.cpp:71:"Fees (in BTC/Kb) smaller than this are considered zero fee for transaction "
src/qt/bitcoinstrings.cpp:232:QT_TRANSLATE_NOOP(  ...  "Fee (in BTC/kB) to add to transactions you send (default: %s)")
src/qt/forms/coincontroldialog.ui:324:          <string notr="true">0.00 BTC</string>
src/rpcblockchain.cpp:405:     " \"value\" : x.xxx,  (numeric) The transaction value in btc\n"
src/rpcmisc.cpp:63:            " \"paytxfee\": x.xxxx,  (numeric) the transaction fee set in btc/kb\n"
src/rpcmisc.cpp:64:            " \"relayfee\": x.xxxx,  (numeric) minimum relay fee for non-free transactions in btc/kb\n"
src/rpcnet.cpp:404:            " \"relayfee\": x.xxxxxxxx,  (numeric) minimum relay fee for non-free transactions in btc/kb\n"
src/rpcrawtransaction.cpp:189: " \"value\" : x.xxx,   (numeric) The value in btc\n"
src/rpcrawtransaction.cpp:376: " \"address\":  ...  the value is the btc amount\n"
src/rpcrawtransaction.cpp:475: " \"value\" : x.xxx,   (numeric) The value in btc\n"

fsb4000
Posts: 13
Joined: Thu Oct 09, 2014 4:27 pm
os: windows

Re: Namecoin Core Qt Rebrand

Post by fsb4000 » Sun May 31, 2015 12:39 am

cassini wrote:There are still a few strings containing "BTC" in ./src/*

Code: Select all

src/amount.cpp:30:   return strprintf("%d.%08d BTC/kB", nSatoshisPerK / COIN, nSatoshisPerK % COIN);
src/init.cpp:335:    strUsage += HelpMessageOpt("-mintxfee=<amt>", strprintf(_("Fees (in BTC/Kb) smaller than ...
src/init.cpp:337:    strUsage += HelpMessageOpt("-paytxfee=<amt>", strprintf(_("Fee (in BTC/kB) to add to ...
src/init.cpp:385:    strUsage += HelpMessageOpt("-minrelaytxfee=<amt>", strprintf(_("Fees (in BTC/Kb) smaller than ...
src/qt/bitcoinstrings.cpp:68:"Fees (in BTC/Kb) smaller than this are considered zero fee for relaying "
src/qt/bitcoinstrings.cpp:71:"Fees (in BTC/Kb) smaller than this are considered zero fee for transaction "
src/qt/bitcoinstrings.cpp:232:QT_TRANSLATE_NOOP(  ...  "Fee (in BTC/kB) to add to transactions you send (default: %s)")
src/qt/forms/coincontroldialog.ui:324:          <string notr="true">0.00 BTC</string>
src/rpcblockchain.cpp:405:     " \"value\" : x.xxx,  (numeric) The transaction value in btc\n"
src/rpcmisc.cpp:63:            " \"paytxfee\": x.xxxx,  (numeric) the transaction fee set in btc/kb\n"
src/rpcmisc.cpp:64:            " \"relayfee\": x.xxxx,  (numeric) minimum relay fee for non-free transactions in btc/kb\n"
src/rpcnet.cpp:404:            " \"relayfee\": x.xxxxxxxx,  (numeric) minimum relay fee for non-free transactions in btc/kb\n"
src/rpcrawtransaction.cpp:189: " \"value\" : x.xxx,   (numeric) The value in btc\n"
src/rpcrawtransaction.cpp:376: " \"address\":  ...  the value is the btc amount\n"
src/rpcrawtransaction.cpp:475: " \"value\" : x.xxx,   (numeric) The value in btc\n"
good job.
I added the changes to the previous commit
(git commit -a --amend)
https://github.com/fsb4000/namecore/com ... 5b087a296d
also I did rebase.
(git rebase namecoin/master)
will update .exe files soon
updated .exe files

fsb4000
Posts: 13
Joined: Thu Oct 09, 2014 4:27 pm
os: windows

Re: Namecoin Core Qt Rebrand

Post by fsb4000 » Sun May 31, 2015 2:17 am

biolizard89 wrote:The splash screen has poor contrast for the text that is overlaid on the Namecoin logo. This isn't a problem for Bitcoin-Qt, since the light shade of orange used by the Bitcoin logo contrasts well with the gray text, but the gray text is pretty similar in color to the shade of blue we use for the Namecoin logo. I'm not certain of the best way to fix this; any graphic designers want to comment here?
Not graphic designer but what if we will just change color from gray to black
Before:
Image
After
Image

fsb4000
Posts: 13
Joined: Thu Oct 09, 2014 4:27 pm
os: windows

Re: Namecoin Core Qt Rebrand

Post by fsb4000 » Sun May 31, 2015 9:55 am

just wondering, what's wrong?

my namecoin-qt.exe https://www.metascan-online.com/en/scan ... 878370b4aa
official bitcoin-qt.exe (0.10.2) https://www.metascan-online.com/en/scan ... e164e8cc0e

How I build:
1) Open MSYS and go to folder with namecoin
2) ./autogen.sh
3)

Code: Select all

CPPFLAGS="-I/c/deps/db-4.8.30.NC/build_unix \
-I/c/deps/openssl-1.0.2/include \
-I/c/deps \
-I/c/deps/protobuf-2.6.1/src \
-I/c/deps/libpng-1.6.15 \
-I/c/deps/qrencode-3.4.4" \
LDFLAGS="-L/c/deps/db-4.8.30.NC/build_unix \
-L/c/deps/openssl-1.0.2 \
-L/c/deps/miniupnpc \
-L/c/deps/protobuf-2.6.1/src/.libs \
-L/c/deps/libpng-1.6.15/.libs \
-L/c/deps/qrencode-3.4.4/.libs" \
BOOST_ROOT=/c/deps/boost_1_57_0 \
./configure \
--disable-upnp-default \
--disable-tests \
--with-gui=qt4 \
--with-qt-incdir=/c/Qt/4.8.6/include \
--with-qt-libdir=/c/Qt/4.8.6/lib \
--with-qt-plugindir=/c/Qt/4.8.6/plugins \
--with-qt-bindir=/c/Qt/4.8.6/bin \
--with-protoc-bindir=/c/deps/protobuf-2.6.1/src
4) make
5) strip src/qt/namecoin-qt.exe
(also strip other binary files)

phelix
Posts: 1631
Joined: Thu Aug 18, 2011 6:59 am

Re: Namecoin Core Qt Rebrand

Post by phelix » Sun May 31, 2015 6:58 pm

fsb4000 wrote:just wondering, what's wrong?
Everything is fine, you did a great job. Thank you very much.

I am fine with black text on the splash screen but would not mind grey either if it less of a hassle for Domob. We will decide on this later.

Please send me a Bitcoin address on this forum by PM or on bitcointalk by PM.
nx.bit - some namecoin stats
nf.bit - shortcut to this forum

fsb4000
Posts: 13
Joined: Thu Oct 09, 2014 4:27 pm
os: windows

Re: Namecoin Core Qt Rebrand

Post by fsb4000 » Mon Jun 01, 2015 1:43 am

phelix wrote:
fsb4000 wrote:just wondering, what's wrong?
Everything is fine, you did a great job. Thank you very much.

I am fine with black text on the splash screen but would not mind grey either if it less of a hassle for Domob. We will decide on this later.

Please send me a Bitcoin address on this forum by PM or on bitcointalk by PM.
I don't think that black text would be hassle.
I created tree https://github.com/fsb4000/namecore/tree/black_text
It is just 1 line change: https://github.com/fsb4000/namecore/com ... 6bc4ac0b06

namecoin-qt(black).exe : https://yadi.sk/d/BP5sKFjYgz6JV

Yes, I know what I didn't add anything virus but I'm just curious if someone builds their own .exe for windows, will this site show the virus warning or not? If not then how do you build?

Thank you, I will send Bitcoin address now.

Created pull request(don't include black text): https://github.com/namecoin/namecore/pull/8

biolizard89
Posts: 1982
Joined: Tue Jun 05, 2012 6:25 am
os: linux

Re: Namecoin Core Qt Rebrand

Post by biolizard89 » Mon Jun 01, 2015 8:32 am

fsb4000 wrote:
phelix wrote:
fsb4000 wrote:just wondering, what's wrong?
Everything is fine, you did a great job. Thank you very much.

I am fine with black text on the splash screen but would not mind grey either if it less of a hassle for Domob. We will decide on this later.

Please send me a Bitcoin address on this forum by PM or on bitcointalk by PM.
I don't think that black text would be hassle.
I created tree https://github.com/fsb4000/namecore/tree/black_text
It is just 1 line change: https://github.com/fsb4000/namecore/com ... 6bc4ac0b06

namecoin-qt(black).exe : https://yadi.sk/d/BP5sKFjYgz6JV

Yes, I know what I didn't add anything virus but I'm just curious if someone builds their own .exe for windows, will this site show the virus warning or not? If not then how do you build?

Thank you, I will send Bitcoin address now.

Created pull request(don't include black text): https://github.com/namecoin/namecore/pull/8
Thanks for your excellent work on this. Black text seems to be a reasonable solution to me, and if it's 1 line then I don't see any reason not to merge it. I don't know what's causing the specific malware warning you noticed, but when I built an old version of namecoind (about 1.5 years ago) from source, several Windows antivirus programs claimed it was malware. I suspect they're using a whitelist, which of course will flag anything built from source non-reproducibly as malware. When I tested your .exe, I did so in a fresh VM to be safe, and I assume the other devs here did the same. (Trust but verify.)

Cheers!
Jeremy Rand, Lead Namecoin Application Engineer
NameID: id/jeremy
DyName: Dynamic DNS update client for .bit domains.

Donations: BTC 1EcUWRa9H6ZuWPkF3BDj6k4k1vCgv41ab8 ; NMC NFqbaS7ReiQ9MBmsowwcDSmp4iDznjmEh5

phelix
Posts: 1631
Joined: Thu Aug 18, 2011 6:59 am

Re: Namecoin Core Qt Rebrand

Post by phelix » Mon Jun 01, 2015 7:32 pm

Coins on the way. We increased the bounty a little for the good work (e.g. builds were not specifically asked). :mrgreen:
nx.bit - some namecoin stats
nf.bit - shortcut to this forum

Post Reply