Namecoin Core Qt Rebrand

fsb4000
Posts: 13
Joined: Thu Oct 09, 2014 4:27 pm
os: windows

Namecoin Core Qt Rebrand

Post by fsb4000 » Tue May 26, 2015 4:26 pm

phelix wrote: 0.1 BTC - Rebrand Namecore (Namecoin Core client)
Replace "Bitcoin" by "Namecoin" (and similar) where appropriate, replace all logos with the new Namecoin logo
Hi. I started work on this bounty.

Could someone test the current version?

Commits: https://github.com/fsb4000/namecore/com ... dd99afe4b8
https://github.com/fsb4000/namecore/com ... 5b087a296d
Windows binary:
namecoin-qt.exe: https://yadi.sk/d/10PQnE1egtBFH
namecoin-cli.exe: https://yadi.sk/d/ZowFSIcfgtBGr
namecoind.exe: https://yadi.sk/d/fj2om8T_gtBKK
namecoin-tx.exe: https://yadi.sk/d/d-LKTVNMgtBLn

Notes:
1) I didn't replace "see the Bitcoin Wiki for SSL setup instructions" because Bitcoin Wiki has
instructions for SSL setup.
2) I didn't replace Bitcoin to Namecoin at Qt translation files because this(and similar : ():
https://github.com/fsb4000/namecore/blo ... ar.ts#L318
Maybe we should open translation project @ https://www.transifex.com/ , how do you think? (it is free for open source projects)
I'm native Russian and I know a bit Ukrainian and Belarusian.
Anyway I will try to partially replace Bitcoin to Namecoin.

If you find unreplaced phrases please write in this topic, I'll replace.
Last edited by fsb4000 on Sun May 31, 2015 12:39 am, edited 2 times in total.

biolizard89
Posts: 1977
Joined: Tue Jun 05, 2012 6:25 am
os: linux

Re: Namecoin Core Qt Rebrand

Post by biolizard89 » Tue May 26, 2015 10:48 pm

fsb4000 wrote:
phelix wrote: 0.1 BTC - Rebrand Namecore (Namecoin Core client)
Replace "Bitcoin" by "Namecoin" (and similar) where appropriate, replace all logos with the new Namecoin logo
Hi. I started work on this bounty.

Could someone test the current version?

Commit: https://github.com/fsb4000/namecore/com ... dd99afe4b8
Windows binary:
namecoin-qt.exe: https://yadi.sk/d/10PQnE1egtBFH
namecoin-cli.exe: https://yadi.sk/d/ZowFSIcfgtBGr
namecoind.exe: https://yadi.sk/d/fj2om8T_gtBKK
namecoin-tx.exe: https://yadi.sk/d/d-LKTVNMgtBLn

Notes:
1) I didn't replace "see the Bitcoin Wiki for SSL setup instructions" because Bitcoin Wiki has
instructions for SSL setup.
2) I didn't replace Bitcoin to Namecoin at Qt translation files because this(and similar : ():
https://github.com/fsb4000/namecore/blo ... ar.ts#L318
Maybe we should open translation project @ https://www.transifex.com/ , how do you think? (it is free for open source projects)
I'm native Russian and I know a bit Ukrainian and Belarusian.
Anyway I will try to partially replace Bitcoin to Namecoin.

If you find unreplaced phrases please write in this topic, I'll replace.
Hi,

Thanks for working on this important task. I'm a little bit preoccupied this week, so hopefully Phelix or someone else can test -- but if not, I'll try to test it out as soon as I can.

Cheers!
Jeremy Rand, Lead Namecoin Application Engineer
NameID: id/jeremy
DyName: Dynamic DNS update client for .bit domains.

Donations: BTC 1EcUWRa9H6ZuWPkF3BDj6k4k1vCgv41ab8 ; NMC NFqbaS7ReiQ9MBmsowwcDSmp4iDznjmEh5

phelix
Posts: 1631
Joined: Thu Aug 18, 2011 6:59 am

Re: Namecoin Core Qt Rebrand

Post by phelix » Wed May 27, 2015 8:02 am

Great! Looks good, e.g. that you exchanged the example Bitcoin addresses to Namecoin addresses.

I will test over the weekend but at a first glance it looks like you earned the bounty - thanks!

fsb4000 also contacted me on bitcointalk.org Here is his user account: https://bitcointalk.org/index.php?actio ... le;u=42514 I guess you are working on improving your trust rating. ;)

Domob originally suggested this bounty, any comments?

edit: don't worry about the translations too much - the latin alphabet is sufficient for now.
nx.bit - some namecoin stats
nf.bit - shortcut to this forum

domob
Posts: 1117
Joined: Mon Jun 24, 2013 11:27 am
Contact:

Re: Namecoin Core Qt Rebrand

Post by domob » Wed May 27, 2015 9:05 am

I have not tested it, only looked at the commit. Looks good to me - the only comment is that we should try to avoid replacements where "not really necessary" in order to make merging upstream patches as easy as possible.

For instance, one hunk of the patch to src/bitcoin-cli.cpp only changes a comment. I think you should remove that change. Furthermore, I have somewhat mixed feelings towards all the changes to the help texts. They are user-visible and make sense, but on the other hand it will introduce conflicts for (presumably me) to manually resolve each time upstream changes some help text of an RPC command. What are other opinions about this? My original intention with the bounty was mostly to change UI stuff in the Qt client (although I like some of the other places where you have spotted "Bitcoin" as well).
BTC: 1domobKsPZ5cWk2kXssD8p8ES1qffGUCm | NMC: NCdomobcmcmVdxC5yxMitojQ4tvAtv99pY
BM-GtQnWM3vcdorfqpKXsmfHQ4rVYPG5pKS
Use your Namecoin identity as OpenID: https://nameid.org/

phelix
Posts: 1631
Joined: Thu Aug 18, 2011 6:59 am

Re: Namecoin Core Qt Rebrand

Post by phelix » Wed May 27, 2015 2:14 pm

I don't care so much about translations and help texts. :mrgreen:
nx.bit - some namecoin stats
nf.bit - shortcut to this forum

biolizard89
Posts: 1977
Joined: Tue Jun 05, 2012 6:25 am
os: linux

Re: Namecoin Core Qt Rebrand

Post by biolizard89 » Wed May 27, 2015 8:37 pm

domob wrote:I have not tested it, only looked at the commit. Looks good to me - the only comment is that we should try to avoid replacements where "not really necessary" in order to make merging upstream patches as easy as possible.

For instance, one hunk of the patch to src/bitcoin-cli.cpp only changes a comment. I think you should remove that change. Furthermore, I have somewhat mixed feelings towards all the changes to the help texts. They are user-visible and make sense, but on the other hand it will introduce conflicts for (presumably me) to manually resolve each time upstream changes some help text of an RPC command. What are other opinions about this? My original intention with the bounty was mostly to change UI stuff in the Qt client (although I like some of the other places where you have spotted "Bitcoin" as well).
Personally I think changing Bitcoin to Namecoin in the RPC help is appropriate.
Jeremy Rand, Lead Namecoin Application Engineer
NameID: id/jeremy
DyName: Dynamic DNS update client for .bit domains.

Donations: BTC 1EcUWRa9H6ZuWPkF3BDj6k4k1vCgv41ab8 ; NMC NFqbaS7ReiQ9MBmsowwcDSmp4iDznjmEh5

fsb4000
Posts: 13
Joined: Thu Oct 09, 2014 4:27 pm
os: windows

Re: Namecoin Core Qt Rebrand

Post by fsb4000 » Thu May 28, 2015 11:47 am

domob wrote:I have not tested it, only looked at the commit. Looks good to me - the only comment is that we should try to avoid replacements where "not really necessary" in order to make merging upstream patches as easy as possible.

For instance, one hunk of the patch to src/bitcoin-cli.cpp only changes a comment. I think you should remove that change. Furthermore, I have somewhat mixed feelings towards all the changes to the help texts. They are user-visible and make sense, but on the other hand it will introduce conflicts for (presumably me) to manually resolve each time upstream changes some help text of an RPC command. What are other opinions about this? My original intention with the bounty was mostly to change UI stuff in the Qt client (although I like some of the other places where you have spotted "Bitcoin" as well).
What if I divide the commit into two commits? (maybe in two branches)
first: changes that can be merged in upstream and don't make update to bitcoin upstream very difficult
second: other changes that you will apply only for new release versions.

I'm not really an git expert, just my thoughts.
If we choose this option, could you clarify what changes move into the second commit?

domob
Posts: 1117
Joined: Mon Jun 24, 2013 11:27 am
Contact:

Re: Namecoin Core Qt Rebrand

Post by domob » Thu May 28, 2015 1:43 pm

I don't think that this helps, either. I'm not strongly opposed to the changes to help texts, since they are clearly actually "correct" and useful. So if others think we should do that, I'm fine with it. (I hope that Bitcoin does not change those too often, but I see no reason why it should.) The only thing I "insist" on is to remove the patch hunk that is only a change to a comment. Apart from that, I'm fine with the patch if others have tested it and ACK it as well. (And I'm also in favour of paying out the bounty when phelix agrees.)
BTC: 1domobKsPZ5cWk2kXssD8p8ES1qffGUCm | NMC: NCdomobcmcmVdxC5yxMitojQ4tvAtv99pY
BM-GtQnWM3vcdorfqpKXsmfHQ4rVYPG5pKS
Use your Namecoin identity as OpenID: https://nameid.org/

biolizard89
Posts: 1977
Joined: Tue Jun 05, 2012 6:25 am
os: linux

Re: Namecoin Core Qt Rebrand

Post by biolizard89 » Fri May 29, 2015 6:33 am

I haven't had a chance to test yet (I'm away from both my Windows VM and my Gitian VM at the moment). Hopefully Phelix can test it; if not I'll test as soon as I can.
Jeremy Rand, Lead Namecoin Application Engineer
NameID: id/jeremy
DyName: Dynamic DNS update client for .bit domains.

Donations: BTC 1EcUWRa9H6ZuWPkF3BDj6k4k1vCgv41ab8 ; NMC NFqbaS7ReiQ9MBmsowwcDSmp4iDznjmEh5

biolizard89
Posts: 1977
Joined: Tue Jun 05, 2012 6:25 am
os: linux

Re: Namecoin Core Qt Rebrand

Post by biolizard89 » Fri May 29, 2015 8:02 am

The splash screen has poor contrast for the text that is overlaid on the Namecoin logo. This isn't a problem for Bitcoin-Qt, since the light shade of orange used by the Bitcoin logo contrasts well with the gray text, but the gray text is pretty similar in color to the shade of blue we use for the Namecoin logo. I'm not certain of the best way to fix this; any graphic designers want to comment here?
Jeremy Rand, Lead Namecoin Application Engineer
NameID: id/jeremy
DyName: Dynamic DNS update client for .bit domains.

Donations: BTC 1EcUWRa9H6ZuWPkF3BDj6k4k1vCgv41ab8 ; NMC NFqbaS7ReiQ9MBmsowwcDSmp4iDznjmEh5

Post Reply